Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop VPN updates and bug fixes (uplift to 1.45.x) #15581

Closed
wants to merge 6 commits into from
Closed

Desktop VPN updates and bug fixes (uplift to 1.45.x) #15581

wants to merge 6 commits into from

Conversation

bsclifton
Copy link
Member

Almost everything here is merged to 1.46.x already
The only ones that aren't in 1.46.x are #15502 and #15560 which are uplifted in #15580

Uplift of #15453
Uplift of #15435
Uplift of #15463
Uplift of #15506
Uplift of #15502
Uplift of #15560
Fixes brave/brave-browser#24331
Fixes brave/brave-browser#25793
Fixes brave/brave-browser#22972
Fixes brave/brave-browser#25773
Fixes brave/brave-browser#25789
Fixes brave/brave-browser#25790

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton bsclifton added this to the 1.46.x - Beta milestone Oct 20, 2022
@bsclifton bsclifton requested a review from a team as a code owner October 20, 2022 22:16
@bsclifton bsclifton self-assigned this Oct 20, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 20, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton
Copy link
Member Author

Closing as we pushing VPN feature in the 1.45.x maintenance release is way too tight at this point

@bsclifton bsclifton closed this Oct 28, 2022
@bsclifton bsclifton deleted the desktop-vpn-uplifts-1.45.x branch October 28, 2022 16:52
@bsclifton bsclifton removed this from the 1.46.x - Beta milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bsclifton bsclifton

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bsclifton @brave-builds @spylogsster @simonhong